Skip to content

Conversation

@swallez
Copy link
Member

@swallez swallez commented Dec 5, 2025

Fixes RR-3012

The url parameter in create_table_entry is now optional. When it's None, the OSS server will create the Lance table in a temporary directory that will be deleted when the process exists.

The path used is $TMPDIR/rerun-data-<xxx>/lance-<some-tuid>, e.g. $TMPDIR/rerun-data-jYteWy/lance-187E63126233FA3A3f7ce35ea997f9c8

@swallez swallez requested review from abey79 and Copilot December 5, 2025 18:11
@swallez swallez added sdk-python Python logging API sdk-rust Rust logging API include in changelog labels Dec 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR allows tables to be created without requiring a URL by making the url parameter optional in create_table_entry. When no URL is provided, the OSS server automatically creates a Lance table in a temporary directory ($TMPDIR/rerun-data-<xxx>/lance-<some-tuid>) that is cleaned up when the process exits.

Key changes:

  • Made the url parameter optional (Option<T>) across Python and Rust APIs
  • Added temporary directory management in RerunCloudHandlerSettings for auto-generated table storage
  • Updated all existing test code to explicitly wrap provider_details in Some()

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rerun_py/tests/e2e_redap_tests/conftest.py Updated create_table signature to accept optional URL
rerun_py/src/catalog/connection_handle.rs Changed url parameter from reference to Option<Url>
rerun_py/src/catalog/catalog_client.rs Added optional URL parsing with map and transpose
rerun_py/rerun_sdk/rerun/catalog/_catalog_client.py Updated Python type hint to accept optional URL
rerun_py/rerun_bindings/rerun_bindings.pyi Updated type stub for optional URL parameter
crates/store/re_server/src/rerun_cloud.rs Added temporary directory creation and auto-generation of table paths when URL is not provided
crates/store/re_redap_tests/src/tests/update_entry.rs Wrapped provider_details in Some() for test compatibility
crates/store/re_redap_tests/src/tests/create_table.rs Wrapped provider_details in Some() for test compatibility
crates/store/re_redap_tests/src/tests/create_dataset.rs Wrapped provider_details in Some() for test compatibility
crates/store/re_redap_client/src/connection_client.rs Changed to create optional provider_details based on URL presence
crates/store/re_protos/src/v1alpha1/rerun.cloud.v1alpha1.rs Fixed typo in comment ("one one" to "one")
crates/store/re_protos/src/v1alpha1/rerun.cloud.v1alpha1.ext.rs Made provider_details optional in request/response conversion logic
crates/store/re_protos/proto/rerun/v1alpha1/cloud.proto Made provider_details field optional in protobuf definition and fixed comment typo

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Web viewer built successfully.

Result Commit Link Manifest
40e3659 https://rerun.io/viewer/pr/12132 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

# Conflicts:
#	rerun_py/rerun_bindings/rerun_bindings.pyi
@swallez swallez force-pushed the swallez/auto-table-url branch from 1e0e93e to 5aef93f Compare December 6, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog sdk-python Python logging API sdk-rust Rust logging API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants