We do not show the analytics disclaimer if a user is authenticating with a rerun account #12133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
ntjohnson1
added
sdk-python
ntjohnson1
approved these changes
Dec 5, 2025
Member
ntjohnson1
left a comment
ntjohnson1
left a comment
There was a problem hiding this comment.
We probably need to have a longer discussion about this (or maybe this is already scoped somewhere else). I would imagine we get to a point where users select different levels of acceptable analytics and that we parse that from their login details.
…eness and let chooser opt-out if they want
ntjohnson1
pushed a commit
that referenced
this pull request
Dec 5, 2025
…ith a rerun account (#12133) Without this, any time a user wants to create an authenticated session in a clean notebook environment, the experience ends up looking like. <img width="720" height="478" alt="image" src="https://github.com/user-attachments/assets/df7d6fee-3ac9-443f-a1ce-d7a8bfc5e697" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Without this, any time a user wants to create an authenticated session in a clean notebook environment, the experience ends up looking like.
