Skip to content

Fix mobile overlay not closing on navigation link clicks #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jderochervlk merged 2 commits into from
Feb 21, 2026
Merged

Fix mobile overlay not closing on navigation link clicks #1198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aced45
Initial plan
Copilot Feb 18, 2026
d995f84
Add onClick handlers to close mobile overlay for all navigation links
Copilot Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/NavbarMobileOverlay.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ module MobileNav = {
prefetch={#intent}
to=#"/blog"
className={linkOrActiveLinkSubroute(~target=#"/blog", ~route)}
onClick=toggleMobileOverlay
>
{React.string("Blog")}
</Link>
Expand All @@ -31,6 +32,7 @@ module MobileNav = {
prefetch={#intent}
to=#"/community/overview"
className={linkOrActiveLink(~target=#"/community/overview", ~route)}
onClick=toggleMobileOverlay
>
{React.string("Community")}
</Link>
Expand All @@ -40,6 +42,7 @@ module MobileNav = {
prefetch={#intent}
to=#"/packages"
className={linkOrActiveLink(~target=#"/packages", ~route)}
onClick=toggleMobileOverlay
>
{React.string("Packages")}
</Link>
Expand All @@ -50,22 +53,23 @@ module MobileNav = {
rel="noopener noreferrer"
className=extLink
ariaLabel="X (formerly Twitter)"
onClick=closeMobileOverlay
>
{React.string("X")}
</a>
</li>
<li className=base>
<a href=Constants.blueSkyHref rel="noopener noreferrer" className=extLink>
<a href=Constants.blueSkyHref rel="noopener noreferrer" className=extLink onClick=closeMobileOverlay>
{React.string("Bluesky")}
</a>
</li>
<li className=base>
<a href=Constants.githubHref rel="noopener noreferrer" className=extLink>
<a href=Constants.githubHref rel="noopener noreferrer" className=extLink onClick=closeMobileOverlay>
{React.string("GitHub")}
</a>
</li>
<li className=base>
<a href=Constants.discourseHref rel="noopener noreferrer" className=extLink>
<a href=Constants.discourseHref rel="noopener noreferrer" className=extLink onClick=closeMobileOverlay>
{React.string("Forum")}
</a>
</li>
Expand Down
Loading