Skip to content

Fix extension crash triggered by incremental compilation #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mediremi merged 3 commits into from
Dec 25, 2025
Merged

Fix extension crash triggered by incremental compilation #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc278f5
Promisify'd child_process.execFile throws if exit code is non-zero
mediremi Dec 24, 2025
e9d5071
Remove unused import
mediremi Dec 24, 2025
cacee02
Add CHANGELOG entry
mediremi Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

- Take namespace into account for incremental cleanup. https://github.com/rescript-lang/rescript-vscode/pull/1164
- Potential race condition in incremental compilation. https://github.com/rescript-lang/rescript-vscode/pull/1167
- Fix extension crash triggered by incremental compilation. https://github.com/rescript-lang/rescript-vscode/pull/1169

#### :nail_care: Polish

Expand Down
8 changes: 6 additions & 2 deletions server/src/incrementalCompilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { fileCodeActions } from "./codeActions";
import { projectsFiles } from "./projectFiles";
import { getRewatchBscArgs, RewatchCompilerArgs } from "./bsc-args/rewatch";
import { BsbCompilerArgs, getBsbBscArgs } from "./bsc-args/bsb";
import { getCurrentCompilerDiagnosticsForFile } from "./server";
Copy link
Member Author

@mediremi mediremi Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import was unused

import { NormalizedPath } from "./utils";
import { getLogger } from "./logger";

Expand Down Expand Up @@ -712,7 +711,12 @@ async function compileContents(
entry.project.bscBinaryLocation,
callArgs,
{ cwd, signal },
);
).catch((error) => {
if (error.stderr) {
return { stderr: error.stderr };
}
throw error;
});

getLogger().log(
`Recompiled ${entry.file.sourceFileName} in ${
Expand Down