Add support for Set, Map, WeakSet and WeakMap to @unboxed #8009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
|
Changes look good 👍 Could you add a CHANGELOG entry for this PR please? |
josher8a
added a commit
to josher8a/rescript
that referenced
this pull request
Nov 11, 2025
Contributor
Author
Done 🫡 |
Member
|
Hi @josher8a! Thanks a lot for your contribution! 🎉 Even though this seems like a low-risk change, we already have a feature freeze for 12.0. |
Member
|
@josher8a master is now on 12.1, so this is good to go! Could you rebase and move the CHANGELOG entry to 12.1? |
josher8a
force-pushed
the
unboxed-set-and-map
branch
from
1a14f23 to
4343d5b
Compare
mediremi
approved these changes
Dec 26, 2025
Member
|
Thanks again @josher8a! |
github-project-automation
bot
moved this from In progress
to Done
in ReScript development
Contributor
Author
|
Anytime! Happy to support the project. I'll keep an eye out for more ways to contribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.