Skip to content

fix: rescript-legacy broken for ppx's #8103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 2 commits into from
Dec 26, 2025
+1 −4
Merged

fix: rescript-legacy broken for ppx's #8103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9061a4a
fix: rescript-legacy broken for ppx's
illusionalsagacity Dec 25, 2025
7430518
Merge branch 'master' into fix-8090-ppx
cknitt Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
- Formatter: normalize underscore placeholders in pipe expressions to canonical form (e.g., `a->map2(_, fn)` formats to `a->map2(fn)`). https://github.com/rescript-lang/rescript/pull/8033
- Fix rewatch panic on duplicate module name. https://github.com/rescript-lang/rescript/pull/8102
- Fix `let?` unwrap to use actual variable names from pattern instead of hardcoded "x"/"e". When using `let? Some(myVar) = ...`, the variable name `myVar` is now properly propagated in early returns. https://github.com/rescript-lang/rescript/issues/8085
- Fix 'Ill-formed list of warnings' errors for ppx's with rescript-legacy. https://github.com/rescript-lang/rescript/pull/8103

#### :memo: Documentation

Expand Down
4 changes: 0 additions & 4 deletions compiler/bsb/bsb_ninja_rule.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,6 @@ let make_custom_rules ~(gentype_config : Bsb_config_types.gentype_config)
(match ppx_files with
| [] -> ()
| _ ->
Ext_list.iter ppx_files (fun x ->
match string_of_float (Unix.stat x.name).st_mtime with
| exception _ -> ()
| st -> Ext_buffer.add_char_string buf ',' st);
Ext_buffer.add_char_string buf ' ' (Bsb_build_util.ppx_flags ppx_files));
(match pp_file with
| None -> ()
Expand Down
Loading