Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cristianoc
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix partial application generalization for
...Summary
Fixes #8334.
ReScript treated
foo(arg, ...)differently fromfoo(arg, _)duringgeneralization:
foo(arg, _)was parsed into an explicit lambda, so it was treated as afunction value and could be generalized.
foo(arg, ...)stayed as a partial application node in the typed tree, so itwas treated as expansive and could end up with weak type variables.
That caused code like this to fail:
with:
Fix
Treat ReScript partial applications with
partial = trueas nonexpansive inthe value restriction check.
This matches the runtime/codegen behavior:
foo(arg, ...)is ultimately loweredto a wrapper function, so it should be classified like an explicit lambda for
generalization purposes.
Tests
Added a regression to
tests/tests/src/PartialApplicationNoRuntimeCurry.rescovering the reported polymorphic callback case:
addHookPartial = addHook(hook, ...)intstringUpdated the expected generated output in the matching
.mjsfixture.