Fix functor module type result-signature brace formatting#8519
Open
MavenRain wants to merge 2 commits into
Open
Fix functor module type result-signature brace formatting#8519MavenRain wants to merge 2 commits into
MavenRain wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77aaf8f19b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Onyeka Obi <softwareengineerasaservant@isurvivable.cv>
shulhi
reviewed
Jul 24, 2026
|
|
||
| module ResultIdent: A => B | ||
|
|
||
| module ResultWith: A => (B with type t = int) |
Member
There was a problem hiding this comment.
@MavenRain can you add module name with a longer name as well (more than 80 characters in one line) to test how the formatter handles that case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix functor module type result-signature brace formatting
Fixes #7949.
Problem
When a functor module type returns a signature, the formatter broke the
opening brace onto its own line:
This is inconsistent with functor module expressions, which already keep the
brace on the same line as
=>:Cause
In
print_mod_type(thePmty_functorarm ofcompiler/syntax/src/res_printer.ml),the arrow was followed by a breakable
Doc.line. Because a signature resultforce-breaks internally, the enclosing group always broke at that
Doc.line,pushing
{to the next line. The siblingprint_mod_functor(moduleexpressions) uses an unconditional hard space (
Doc.text " => ") and so neverhad this problem.
Fix
When the functor result is a signature, use a hard space before it (hug the
brace); otherwise keep the breakable
Doc.lineso long non-signature results(idents,
withconstraints, curried arrows) can still wrap:Testing
tests/syntax_tests/data/printer/modType/functorInterface.resicovering the reported
.resicase plus curried params, a nested/curried arrow,an empty signature, and non-signature results (which must remain unchanged).
(
modType/functor.res.txtmodule type B = () => {, andmodExpr/structure.res.txtmodule G0: (X: {}) => {).make test-syntaxandmake test-syntax-roundtrippass; the printer +idempotency corpus round-trips with no diff, and comments around
=>/ insidethe result signature are preserved.
Drafted with AI assistance; the change, tests, and verification were reviewed by me.