Conversation
Use yamlfix to fix a few issues reported by yamllint,
# yamllint .packit.yaml
.packit.yaml
40:81 error line too long (88 > 80 characters) (line-length)
41:81 error line too long (122 > 80 characters) (line-length)
46:13 warning comment not indented like content (comments-indentation)
46:81 error line too long (119 > 80 characters) (line-length)
Signed-off-by: Coiby Xu <coxu@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .packit.yaml configuration, primarily adding a new test job for image-mode Fedora and reformatting existing entries for consistency. Review feedback identified two critical issues in the new job configuration: the use_internal_tf flag is set to true despite the requirement for the public Testing Farm instance, and the target fedora-44-image-mode appears to be a typo as Fedora 44 is not yet a valid release.
.packit.yaml
Outdated
| targets: [fedora-44-image-mode] | ||
| identifier: image-mode | ||
| fmf_path: kernel-tests-plans | ||
| use_internal_tf: true |
There was a problem hiding this comment.
The pull request description states that "Currently only public testing farm instance supports image-mode Fedora," but the configuration for this new job sets use_internal_tf: true. This will cause the job to run on the internal Testing Farm instance where the target may not be available. This should be set to false to use the public instance as intended.
use_internal_tf: false
coiby
force-pushed
the
image_mode_tests
branch
4 times, most recently
from
0f00e2c to
67608c3
Compare
Currently only public testing farm instance supports image-mode Fedora. And to run mulitple tests, an identifier is needed [1]. [1] https://packit.dev/docs/configuration/upstream/tests Signed-off-by: Coiby Xu <coxu@redhat.com>
1 participant
tests: Test against image-mode Fedora
Currently only public testing farm instance supports image-mode Fedora.
And to run mulitple tests, an identifier is needed [1].
[1] https://packit.dev/docs/configuration/upstream/tests