Make empty params to request give no query string#29
Open
rutchkiwi wants to merge 1 commit intoring-clojure:masterfrom
Open
Make empty params to request give no query string#29rutchkiwi wants to merge 1 commit intoring-clojure:masterfrom
rutchkiwi wants to merge 1 commit intoring-clojure:masterfrom
Conversation
The previous behaviour was to insert an empty query string for an empty map of params, but leave out the key in case it was nil. This change makes it consistently leave out the :query-string in both cases. The previous behaviour caused problems when using the ring request/request-url function - it would (and still does as of time of writing) add a trailing ? to the url when the empty query string is there. This can be confusing. Discussion: ring-clojure/ring#543 (comment)
Author
|
Apologies for the kinda confusing commit message - I couldn't figure out how to phrase this better... Let me know if you think it makes sense, otherwise I can think of how to rephrase it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behaviour was to insert an empty query string for an empty map of params, but leave out the key in case it was nil. This change makes it consistently leave out the :query-string in both cases.
The previous behaviour caused problems when using the ring request/request-url function - it would (and still does as of time of writing) add a trailing ? to the url when the empty query string is there. This can be confusing.
Discussion: ring-clojure/ring#543 (comment)