Skip to content

feat(sandbox): keep mount endpoints stable - #1886

Open
VAIBHAVSING wants to merge 2 commits into
rivet-dev:mainfrom
VAIBHAVSING:feat/sandbox-stable-mount-endpoints
Open

feat(sandbox): keep mount endpoints stable#1886
VAIBHAVSING wants to merge 2 commits into
rivet-dev:mainfrom
VAIBHAVSING:feat/sandbox-stable-mount-endpoints

Conversation

@VAIBHAVSING

Copy link
Copy Markdown
  • Add a stable authenticated per-VM relay for native sandbox filesystem mounts.
  • Share lazy single-flight lifecycle state between filesystem and process binding operations, including idle replacement and credential rotation.
  • Add replacement coverage and document the updated sandbox lifecycle.

Closes #1826

@VAIBHAVSING
VAIBHAVSING marked this pull request as ready for review August 7, 2026 16:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92ab1b7d88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

this.#clearIdleTimer();
const errors: unknown[] = [];
try {
await this.#startPromise;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid awaiting in-flight sandbox startup during dispose

When dispose() is called while the first provider-backed sandbox operation is still inside provider.start(), this await makes VM teardown depend on that startup finishing. With the documented startupTimeoutMs: 0 setting, a hung provider start makes AgentOs.dispose() hang forever; even with the default timeout, the disposed-path startup promise later rejects after cleaning up the late client, so disposal reports a startup failure rather than completing cleanup.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(sandbox): keep mount endpoints stable across sandbox restarts

1 participant