fix(rivetkit): validate runner version fits in u32#4417
fix(rivetkit): validate runner version fits in u32#4417NathanFlurry wants to merge 1 commit intomainfrom
Conversation
|
🚅 Deployed to the rivet-pr-4417 environment in rivet-frontend
|
PR ReviewThis is a clean, targeted fix for a real bug. The root cause is well-identified and the solution is minimal. Positive observations
Minor issues
No automated tests for the validation The PR's own test plan is manual. A short unit test exercising the schema with values like SummaryThe fix is correct and the change is minimal. The two guard gaps ( |
Summary
u32for runner version, but nothing prevented the TypeScript client from sending values that overflow itDate.now()(milliseconds) produces values like1773390978291which exceedu32::MAX(4294967295), causing the engine's metadata endpoint to returninvalid_response_jsonDate.now() / 1000if the value is too largeTest plan
Math.floor(Date.now() / 1000)still works as a valid version