feat(rivetkit): redesign sandbox actor module#4424
feat(rivetkit): redesign sandbox actor module#4424NathanFlurry wants to merge 3 commits intomainfrom
Conversation
|
🚅 Deployed to the rivet-pr-4424 environment in rivet-frontend
|
|
PR Review: feat(rivetkit): redesign sandbox actor module This is a significant and well-structured PR that introduces a clean provider-plugin architecture for sandbox actors. STRENGTHS
ISSUES AND CONCERNS
MINOR NOTES
TEST COVERAGE The driver test (actor-sandbox.ts) and provider mock tests (sandbox-providers.test.ts) are solid. The parity test is particularly valuable. Consider adding: a test for the provider mismatch error path on wake, and a test for post-destroy read-only access (sessions/events still queryable after destroy()). OVERALL High-quality work. The architecture is sound, the documentation is thorough, and the parity test is a great safeguard. Main actionable items: error cleanup in Docker on failed start, making idle timeouts configurable, and style nits per CLAUDE.md. |
Summary
Testing