fix(cache): clean up lib#4457
fix(cache): clean up lib#4457MasterPtato wants to merge 1 commit into03-18-fix_config_allow_configuring_topo_dcs_via_map_fix_pg_ssl_mode_configfrom
Conversation
|
🚅 Deployed to the rivet-pr-4457 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Cache Lib Cleanup — ReviewOverall this is a solid cleanup that simplifies the API, removes dead code, and improves type safety. A few issues need addressing before merge. Bug: Integration Tests Will Not CompileThe integration test file (
This means the crate will fail to compile after this PR. The rate-limit-related tests should be deleted alongside the implementation, and the other tests should be updated to the new API. Minor Issues
Undocumented capacity bump: The default in-memory cache capacity was silently changed from 1000 to 10000 entries. This is likely intentional and correct (1000 was probably too low), but it deserves a comment or PR description note since it has a direct impact on per-instance memory usage. What's Good
|
175706a to
17d21f5
Compare
f07072d to
ea5642d
Compare
17d21f5 to
de18421
Compare
ea5642d to
f6c3742
Compare
de18421 to
e65f84d
Compare
e65f84d to
65200cf
Compare
f6c3742 to
10c9ce3
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: