fix(snapshotter): add withLogo support and Android bounds parity#4154
Open
jackashton wants to merge 2 commits intornmapbox:mainfrom
Open
fix(snapshotter): add withLogo support and Android bounds parity#4154jackashton wants to merge 2 commits intornmapbox:mainfrom
jackashton wants to merge 2 commits intornmapbox:mainfrom
Conversation
jackashton
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
jackashton
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
jackashton
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
jackashton
changed the title
mfazekas
approved these changes
Feb 21, 2026
android/src/main/java/com/rnmapbox/rnmbx/modules/RNMBXSnapshotModule.kt
Outdated
Show resolved
Hide resolved
…Module.kt Co-authored-by: Miklós Fazekas <mfazekas@szemafor.com>
jackashton
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
In progress
jackashton
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
In progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withLogooption support to iOS and Android snapshot modulesboundssupport to Android to match existing iOS implementationProblem
The
withLogooption exists in TypeScript types but was ignored by native code. Theboundsoption worked on iOS but not Android.Solution
iOS: Set
mapSnapshotOptions.showsLogofrom thewithLogooptionAndroid:
SnapshotOverlayOptions(showLogo)to Snapshotterboundssupport viasnapshotter.cameraForCoordinates()Test Plan
Updated
TakeSnapshotexample to demonstrate:withLogo: true(shows logo)withLogo: false(hides logo)boundsoption (alternative tocenterCoordinate)iOS tested
Android tested