fix(android): fix onMapSteady event crash#4162
Merged
Conversation
Event key was "topOnMapSteady" which doesn't match the codegen-registered name. Use "onMapSteady" to match the JS prop directly. Fixes #4105
- Override toJSON() in MapSteadyEvent to return flat payload (not wrapped in type/payload structure) so JS receives fields on nativeEvent directly - Fix timer leak in scheduleQuietCheck — cancel previous before scheduling - Fix scheduleTimeout to not reset on every markActivity, enabling periodic heartbeat timeouts during long gestures - Remove emittedForCurrentActivity flag (no longer needed with timer fixes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CameraGestureObserver crash on Android:
Unsupported top level event type "topOnMapSteady" dispatched. The event key didn't match the codegen-registered name. Changed toonMapSteadyto match the JS prop directly.Fixes #4105