Skip to content

Comments

Fixed #147 Added NamespaceTokenFixer to fix unscoped namespace strings#149

Open
danielmorell wants to merge 2 commits intomasterfrom
fixed/issue-147-class-name-collision
Open

Fixed #147 Added NamespaceTokenFixer to fix unscoped namespace strings#149
danielmorell wants to merge 2 commits intomasterfrom
fixed/issue-147-class-name-collision

Conversation

@danielmorell
Copy link
Collaborator

Description of the change

This PR resolves #147. It contains two primary changes:

  1. It adds a class NamespaceTokenFixer that walks through files token by token to fix namespaces in strings in the composer autoload files.
  2. It adds a more robust way of testing by creating a plugin aptly named "conflict" that has dependencies that conflict with the Rollbar plugin when not properly scoped. If the conflict plugin can be activated and the tests pass the Rollbar plugin will be able to safely run in a WordPress installation with other plugins.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danielmorell danielmorell requested a review from brianr February 20, 2026 22:26
@danielmorell danielmorell added this to the v3.1.2 milestone Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal Error: Class name collision between main project's Psr\Log\AbstractLogger and Rollbar plugin's namespaced version

1 participant