[cling] Ensure HeaderFileInfo exists during incremental parsing #21250
Open
devajithvs wants to merge 2 commits intoroot-project:masterfrom
Open
[cling] Ensure HeaderFileInfo exists during incremental parsing #21250devajithvs wants to merge 2 commits intoroot-project:masterfrom
devajithvs wants to merge 2 commits intoroot-project:masterfrom
Conversation
devajithvs
requested review from
dpiparo,
pcanal and
vgvassilev
as code owners
devajithvs
force-pushed
the
fix-autocomplete-backup
branch
from
d16ac58 to
4807d45
Compare
Test Results 22 files 22 suites 3d 6h 59m 19s ⏱️ For more details on these failures, see this check. Results for commit c5c6d5b. ♻️ This comment has been updated with latest results. |
devajithvs
force-pushed
the
fix-autocomplete-backup
branch
4 times, most recently
from
0140bbd to
acb7831
Compare
Contributor
Author
|
Upstreaming fixes: llvm/llvm-project#182044, llvm/llvm-project#182070 |
When registering incremental inputs as virtual files, we need to ensure that the `HeaderSearch` is aware of the `FileEntry`. This prevents assertions in `HeaderSearch::LookupFile` where it expects file info to exist. This will help revert one of our LLVM patches that was added when upgrading to LLVM20.
This reverts commit 94bea4b.
devajithvs
force-pushed
the
fix-autocomplete-backup
branch
from
acb7831 to
c5c6d5b
Compare
devajithvs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering incremental inputs as virtual files, we need to ensure that the
HeaderSearchis aware of theFileEntry.This prevents assertions in
HeaderSearch::LookupFilewhere it expects file info to exist.This will help revert one of our LLVM patches that was added when upgrading to LLVM20.
TODO: Update LLVM tag after review and squash commits.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #