[ntuple] Attributes: add support for writing#21289
Open
silverweed wants to merge 6 commits intoroot-project:masterfrom
Open
[ntuple] Attributes: add support for writing#21289silverweed wants to merge 6 commits intoroot-project:masterfrom
silverweed wants to merge 6 commits intoroot-project:masterfrom
Conversation
Test Results 18 files 18 suites 2d 16h 52m 6s ⏱️ Results for commit 8c48e47. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_attr_write
branch
from
a7e169a to
c82221f
Compare
silverweed
force-pushed
the
ntuple_attr_write
branch
from
c82221f to
8c48e47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
adds the
RNTupleAttrSetWriterclass and initial support for writing attributes. This involves touching, among other classes, the RNTupleWriter, RNTupleFillContext, RPageSink and RMiniFile.Original reference PR (now quite outdated): #19153
Checklist: