[hist] Prepare for explicit object ownership model#21296
Merged
hageboeck merged 4 commits intoroot-project:masterfrom Feb 19, 2026
Merged
[hist] Prepare for explicit object ownership model#21296hageboeck merged 4 commits intoroot-project:masterfrom
hageboeck merged 4 commits intoroot-project:masterfrom
Conversation
When histograms get added to a THStack, they are likely in multiple TLists. Therefore, the kMustCleanup bit must be set. In the past, the bit usually got set automatically when histograms added themselves to directories, but when this is disabled, the cleanup bit remained unset.
The function documentation explicitly states that the histograms created by these operations are added to the current directory, so this is done explicitly here. This makes the code independent of whether implicit ownership is on or off.
This makes TEfficiency consistent with other histogram-like classes, in the sense that it only adds itself to a directory if the corresponding flags are on.
hageboeck
force-pushed
the
root7-ownership-15
branch
from
5e5e7c1 to
1905003
Compare
2 tasks
Test Results 22 files 22 suites 3d 16h 59m 5s ⏱️ Results for commit 1905003. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TH1::AddDirectoryStatus()to TEfficiency