Skip to content

[dict] Error out when no selection file is provided#21298

Merged
dpiparo merged 1 commit intoroot-project:masterfrom
dpiparo:fix_ROOT-5174
Feb 19, 2026
Merged

[dict] Error out when no selection file is provided#21298
dpiparo merged 1 commit intoroot-project:masterfrom
dpiparo:fix_ROOT-5174

Conversation

@dpiparo
Copy link
Copy Markdown
Member

@dpiparo dpiparo commented Feb 17, 2026

Addresses ROOT-5174

@dpiparo dpiparo self-assigned this Feb 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 17, 2026

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0d3f95d.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo force-pushed the fix_ROOT-5174 branch 3 times, most recently from 5d1d29b to 50fb430 Compare February 18, 2026 20:30
- ROOT now adds a RUNPATH to compiled macros. This ensures that when compiled macros are loaded, they load the libraries that belong to the ROOT installation
that compiled the macro. See [TSystem::SetMakeSharedLib()](https://root.cern.ch/doc/master/classTSystem.html#a80cd12e064e2285b35e9f39b5111d20e) for
customising or disabling the RUNPATH.
- `rootcling` fails if no selection rule is specified and if the creation of a C++ module is requested.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `rootcling` fails if no selection rule is specified and if the creation of a C++ module is requested.
- `rootcling` fails if no selection rule is specified and the creation of a C++ module is not requested.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅
Thanks.

… requested

- Adapt some files and tests
- Add a test for the new behaviour
- Update release notes

Addresses ROOT-5174
@dpiparo dpiparo added skip ci Skip the full builds on the actions runners labels Feb 19, 2026
@dpiparo dpiparo marked this pull request as ready for review February 19, 2026 13:31
@dpiparo dpiparo requested a review from bellenot as a code owner February 19, 2026 13:31
@dpiparo dpiparo merged commit d3b8985 into root-project:master Feb 19, 2026
10 checks passed
@dpiparo dpiparo deleted the fix_ROOT-5174 branch February 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip ci Skip the full builds on the actions runners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants