Skip to content

[math] Add missing includes required for std::copy.#21313

Merged
hageboeck merged 3 commits intoroot-project:masterfrom
hageboeck:missingHeader
Feb 19, 2026
Merged

[math] Add missing includes required for std::copy.#21313
hageboeck merged 3 commits intoroot-project:masterfrom
hageboeck:missingHeader

Conversation

@hageboeck
Copy link
Member

@hageboeck hageboeck commented Feb 18, 2026

std::copy stopped to compile on Mac beta, unless <algorithm> is included.

In doing that, clangd claimed that <iostream> is unnecessary in FitData.h, so I removed it.

For reference, #21311 failed with:

  [ 56%] Generating G__ROOTHist.cxx, ../../lib/ROOTHist.pcm
  In file included from input_line_10:10:
  In file included from /Users/sftnight/ROOT-CI/build/include/Fit/BinData.h:16:
  /Users/sftnight/ROOT-CI/build/include/Fit/FitData.h:346:21: error: no member named 'copy' in namespace 'std'
                 std::copy(fCoordsPtr[i], fCoordsPtr[i] + fNPoints + padding, fCoords[i].begin());
                 ~~~~~^
  Error: /Users/sftnight/ROOT-CI/build/bin/rootcling: compilation failure (/Users/sftnight/ROOT-CI/build/lib/libMathCoref28027eebe_dictUmbrella.h)
  make[2]: *** [math/mathcore/G__MathCore.cxx] Error 1
  make[1]: *** [math/mathcore/CMakeFiles/G__MathCore.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....

Edit:
Same error for GSLSimAnnealing.h, checking for more problems.

@hageboeck hageboeck self-assigned this Feb 18, 2026
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hageboeck hageboeck changed the title [math] Add a missing include for FitData.h. [math] Add a missing includes required for std::copy. Feb 18, 2026
std::copy stopped compiling on Mac beta, unless <algorithm> is included.
@hageboeck hageboeck changed the title [math] Add a missing includes required for std::copy. [math] Add missing includes required for std::copy. Feb 18, 2026
Fix a warning when ACLiC runs:
  /Users/sftnight/ROOT-CI/build/bindings/pyroot/cppyy/cppyy/test/./stltypes.h:81:12: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
     81 |     static const size_t size() { return sz; }
        |            ^~~~~
@github-actions
Copy link

Test Results

    22 files      22 suites   3d 5h 51m 15s ⏱️
 3 793 tests  3 789 ✅ 0 💤 4 ❌
75 413 runs  75 409 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 2cb47f7.

Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stephan!

@hageboeck
Copy link
Member Author

Things are compiling again on mac beta, but we need to find the source of the test failures next.

@hageboeck hageboeck merged commit 4b298b7 into root-project:master Feb 19, 2026
27 of 30 checks passed
@hageboeck hageboeck deleted the missingHeader branch February 19, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments