[math] Add missing includes required for std::copy.#21313
Merged
hageboeck merged 3 commits intoroot-project:masterfrom Feb 19, 2026
Merged
[math] Add missing includes required for std::copy.#21313hageboeck merged 3 commits intoroot-project:masterfrom
std::copy.#21313hageboeck merged 3 commits intoroot-project:masterfrom
Conversation
26ec28e to
865b8ca
Compare
std::copy.
std::copy stopped compiling on Mac beta, unless <algorithm> is included.
865b8ca to
54fe750
Compare
std::copy.std::copy.
Fix a warning when ACLiC runs:
/Users/sftnight/ROOT-CI/build/bindings/pyroot/cppyy/cppyy/test/./stltypes.h:81:12: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
81 | static const size_t size() { return sz; }
| ^~~~~
Test Results 22 files 22 suites 3d 5h 51m 15s ⏱️ For more details on these failures, see this check. Results for commit 2cb47f7. |
Member
Author
|
Things are compiling again on mac beta, but we need to find the source of the test failures next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::copy stopped to compile on Mac beta, unless
<algorithm>is included.In doing that, clangd claimed that
<iostream>is unnecessary in FitData.h, so I removed it.For reference, #21311 failed with:
Edit:
Same error for GSLSimAnnealing.h, checking for more problems.