Skip to content

[test] rm outdated comment and add bmp#21750

Open
ferdymercury wants to merge 6 commits intoroot-project:masterfrom
ferdymercury:patch-15
Open

[test] rm outdated comment and add bmp#21750
ferdymercury wants to merge 6 commits intoroot-project:masterfrom
ferdymercury:patch-15

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Mar 31, 2026

No description provided.

@ferdymercury ferdymercury marked this pull request as ready for review March 31, 2026 07:36
@ferdymercury ferdymercury requested a review from dpiparo as a code owner March 31, 2026 07:36
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Mar 31, 2026

thanks for this. Are we sure we can unconditionally go for tiff?

@dpiparo dpiparo self-assigned this Mar 31, 2026
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Mar 31, 2026

Are we sure we can unconditionally go for tiff?

mac14 says no :)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026 •
edited
Loading

Test Results

    22 files      22 suites   3d 2h 26m 2s ⏱️
 3 836 tests  3 785 ✅  1 💤 50 ❌
75 716 runs  75 648 ✅ 18 💤 50 ❌

For more details on these failures, see this check.

Results for commit da25bb6.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury changed the title [test] rm outdated comment and add bmp and tiff [test] rm outdated comment and add bmp Apr 1, 2026
@ferdymercury ferdymercury reopened this Apr 1, 2026
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Apr 7, 2026

debian13 failure seems unrelated. Could someone restart it?

@ferdymercury ferdymercury mentioned this pull request Apr 7, 2026
Open
@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Apr 7, 2026

Are we sure we can unconditionally go for tiff?

The other option would be to change behavior and treat tiff as we treat now png, jpg, gif.

Meaning we get rid of one ROOT build option (asimage_tiff), and require alwayas TIFF to be installed if "asimage" is ON, and provide a builtin opt-in in LCG if not system-wide installed and user requests so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dpiparo dpiparo

Labels

in:Graphics pr:squash on merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ferdymercury @dpiparo