[Net] Remove TNetFile and TNetFileStager, update documentation#21799
Draft
dpiparo wants to merge 4 commits intoroot-project:masterfrom
Draft
[Net] Remove TNetFile and TNetFileStager, update documentation#21799dpiparo wants to merge 4 commits intoroot-project:masterfrom
TNetFile and TNetFileStager, update documentation#21799dpiparo wants to merge 4 commits intoroot-project:masterfrom
Conversation
rootd is not present since ROOT 6.16
TNetFile relied on rootd, which was removed in ROOT release 6.16. TXNetFile, deriving from it, was removed in release 6.34.
making it visible to Doxygen
Test Results 22 files 22 suites 3d 4h 52m 41s ⏱️ For more details on these failures, see this check. Results for commit 874eba1. ♻️ This comment has been updated with latest results. |
pcanal
reviewed
Apr 6, 2026
| } else { | ||
| hfile = new TFile(gFilename, "RECREATE", "TTree benchmark ROOT file"); | ||
| } | ||
| hfile = new TFile(gFilename, "RECREATE", "TTree benchmark ROOT file"); |
Member
There was a problem hiding this comment.
Suggested change
| hfile = new TFile(gFilename, "RECREATE", "TTree benchmark ROOT file"); | |
| hfile = TFile::Open(gFilename, "RECREATE", "TTree benchmark ROOT file"); |
Member
Author
|
There is a big overlap I did not notice, apologies. Let me rescope the PR. |
Member
Author
|
I approved #21775 . |
Member
Author
|
Superseeded by #21775 |
Member
|
from #21775 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title says it all.
Both classes relied on
rootd, which was removed in release 6.16.The
rpdutilswere also removed.Some documentation was made visible to Doxygen and the Release Notes updated.