[afterimage] fix corrupt loop index when bmp bitcount is 16 and correctly normalize 5-bit color#21801
Open
ferdymercury wants to merge 2 commits intoroot-project:masterfrom
Open
[afterimage] fix corrupt loop index when bmp bitcount is 16 and correctly normalize 5-bit color#21801ferdymercury wants to merge 2 commits intoroot-project:masterfrom
ferdymercury wants to merge 2 commits intoroot-project:masterfrom
Conversation
Fixes root-project#8125 x is the loop variable for both data and buf buf->color contains N elements data contains 2*N elements hence, keep separate indices for each array.
ferdymercury
changed the title
This is needed for correct color normalization, since buf-> expects a range between 0 and 255 but data contains 5-bit colors from 0 to 31.
Test Results 21 files 21 suites 2d 22h 41m 16s ⏱️ Results for commit 5bd9897. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8125
x is the loop variable for both data and buf
buf->color contains N elements
data contains 2*N elements
hence, keep separate indices for each array.
A further change is needed for correct color normalization, since buf-> expects a range between 0 and 255 but data contains 5-bit colors from 0 to 31.
Found the fix thanks to easy debug via #21649
Checklist:
Now BMP file in the issue correctly shows: