[RF] Don't disable dirty flag propagation during numeric integrals#21807
Open
guitargeek wants to merge 3 commits intoroot-project:masterfrom
Open
[RF] Don't disable dirty flag propagation during numeric integrals#21807guitargeek wants to merge 3 commits intoroot-project:masterfrom
guitargeek wants to merge 3 commits intoroot-project:masterfrom
Conversation
This is not needed and causes problems when using non-value servers as the target function of numeric integrals, in which case the value needs to be re-set in `RooRealIntegral::evaluate()`, relying on a correctly set up dirty state propagation.
Disabling RooFits internal caching with `setDirtyInhibit(true)` when evaluating numeric integrals can result in huge performance hits when the target function is expensive to compute, for example if it contains a numeric integral itself. Closes root-project#21788.
This reverts commit d1c43b5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling RooFits internal caching with
setDirtyInhibit(true)when evaluating numeric integrals can result in huge performance hits when the target function is expensive to compute, for example if it contains a numeric integral itself.Closes #21788.