Move get_log_directory to improve compilation time - #3214
Merged
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
jmachowinski
approved these changes
Jul 30, 2026
Contributor
Author
|
Pulls: #3214
|
fujitatomoya
approved these changes
Jul 31, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with green CI. (note thta this is a source-breaking change, which is fine for rolling.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
get_log_directoryto another cpp file, then we can avoid to include<filesystem>with therlcpp/logger.cpp. I can't see where this function is used in the core packages.reduce almost 25 seconds
Did you use Generative AI?
Claude Opus 4.7