switching to @profoundlogic/hogan #568
Conversation
|
Hi. I saw this was previously declined due to build issues. I made some changes and now the build and test commands all succeed. Please let me know if there's anything else I need to do on my end. |
scripts/profoundlogic__hogan.d.ts
Outdated
There was a problem hiding this comment.
@jroytman Thanks for opening this PR! I've been a proponent of removing the hogan.js dependency (see #435 (comment)) so it's cool to hear that an actively maintained package exists which is nearly a drop-in alternative 😋
I'm curious if this file can be removed as it appears to be almost a duplicate of typings/profoundlogic__hogan.d.ts.
There was a problem hiding this comment.
Yeah you're right about that. I've removed the duplicate file and updated the reference to point to typings/. All builds and tests pass locally. Let me know if there's anything else you need me to do.
The type definitions in typings/ directory are sufficient. Updated the triple-slash reference in scripts/hulk.ts to point to the correct location.
|
Please let me know if there’s anything further required on my end for approval. |
|
@t1m0thyj Is there anything left for me to do, or is this in your court now to approve? |
@jroytman I reviewed the PR only as an interested member of the community. @rtfpessoa is the owner of the repo 🙂 |
|
Sorry for the delay, will take a look now and try to also get other deps updated |
|
Released as 3.4.53 |
3 participants
This update replaces the long-unmaintained hogan.js dependency, which hasn’t been updated in over a decade and still relies on deprecated modules like mkdirp. The new dependency, @profoundlogic/hogan, is a maintained fork that preserves full compatibility with the original Hogan.js library while removing outdated dependencies and ensuring compatibility with modern Node.js versions. This change helps eliminate installation warnings and keeps the project aligned with current package standards.