Skip to content

activerecord: Remove redundant steep:ignore FallbackAny comments#1040

Merged
github-actions[bot] merged 1 commit into
ruby:mainfrom
kozy4324:activerecord-remove-redundant-comment
Jun 16, 2026
Merged

activerecord: Remove redundant steep:ignore FallbackAny comments#1040
github-actions[bot] merged 1 commit into
ruby:mainfrom
kozy4324:activerecord-remove-redundant-comment

Conversation

@kozy4324

Copy link
Copy Markdown
Contributor

steep 2.0.0 reports these as Ruby::RedundantIgnoreComment errors.

activerecord-generated.rb:39:69: [error] Redundant ignore comment
│ Diagnostic ID: Ruby::RedundantIgnoreComment
│
└ User.preload(:address, friends: [:address, { followers: :users }]) # steep:ignore FallbackAny

The ignore comments were no longer needed, so they were removed.

steep 2.0.0 reports these as `Ruby::RedundantIgnoreComment` errors.
@github-actions

Copy link
Copy Markdown

@kozy4324 Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, @tk0miya, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

@ksss ksss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions

Copy link
Copy Markdown

Thanks for your review, @ksss!

@kozy4324, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@kozy4324

Copy link
Copy Markdown
Contributor Author

/merge

@github-actions github-actions Bot merged commit 3099a93 into ruby:main Jun 16, 2026
7 checks passed
@kozy4324 kozy4324 deleted the activerecord-remove-redundant-comment branch June 16, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants