Remove ruby-title class#1694
Merged
st0012 merged 1 commit intoruby:masterfrom May 6, 2026
Merged
Conversation
It was added for sdoc in ruby@acc499b But since rails/sdoc@41a790b it doesn't use it anymore, and rdoc has no use for it as well.
Earlopain
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR removes the ruby-title CSS class from Ruby syntax-highlighted HTML output generated by RDoc, aligning RDoc’s output with the fact that SDoc no longer relies on that class and RDoc itself doesn’t use it.
Changes:
- Remove
ruby-titlespan classification logic fromRDoc::TokenStream.to_html. - Update
ToHtmlmarkup tests to match the new HTML output (method names/operators no longer carryruby-title).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/rdoc/token_stream.rb |
Removes the special-case tracking that added ruby-title to identifiers following def. |
test/rdoc/markup/to_html_test.rb |
Updates expected HTML output for Ruby verbatim highlighting to no longer include ruby-title. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
🚀 Preview deployment available at: https://df4afe8c.rdoc-6cd.pages.dev (commit: e74ac71) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was added for sdoc in acc499b
But since rails/sdoc@41a790b it doesn't use it anymore, and rdoc has no use for it as well.