Use prism to check if code is valid#1695
Merged
tompng merged 1 commit intoruby:masterfrom May 5, 2026
Merged
Conversation
A bit nicer than what it currently does
Earlopain
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR replaces RDoc::Markup::ToHtml#parseable?’s eval-based Ruby syntax check with Prism.parse_success?, so implicit Ruby code-block detection uses Prism instead of the interpreter parser.
Changes:
- Add an explicit
require 'prism'to the HTML formatter. - Replace the
eval/SyntaxErrorcheck inparseable?withPrism.parse_success?.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| false | ||
| ensure | ||
| $VERBOSE = verbose | ||
| Prism.parse_success?(text) |
tompng
approved these changes
May 5, 2026
Collaborator
|
🚀 Preview deployment available at: https://58feee03.rdoc-6cd.pages.dev (commit: f85b987) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit nicer than what it currently does