HOLD: Add admin-only option to skip the payer confirmation email (bulk payments)#1627
Open
maebeale wants to merge 3 commits into
Open
HOLD: Add admin-only option to skip the payer confirmation email (bulk payments)#1627maebeale wants to merge 3 commits into
maebeale wants to merge 3 commits into
Conversation
maebeale
commented
Jun 11, 2026
| @@ -48,9 +48,8 @@ def create | |||
| notice: "Your bulk payment information has been submitted." | |||
| end | |||
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: on_behalf? is gated by allowed_to?(:dashboard?, @event) so a logged-out visitor can never set on_behalf=1 to suppress the payer confirmation — the param alone is not enough.
maebeale
commented
Jun 11, 2026
| if @send_confirmation | ||
| payer_email = person.preferred_email.presence || field_value("payer_email")&.strip | ||
| if payer_email.present? | ||
| NotificationServices::CreateNotification.call( |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Only the payer confirmation is gated by @send_confirmation; the staff FYI always sends. This matches PR #1626 — on-behalf submissions still notify staff, they just do not email the payer.
maebeale
commented
Jun 11, 2026
| # matches the submission's own role (e.g. a "bulk_payment" submission maps to | ||
| # the event_form with role "bulk_payment"). | ||
| def event | ||
| form.events.find_by(event_forms: { role: role }) |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: Resolves the event by matching the submission role against the event_forms join role (e.g. bulk_payment), since FormSubmission has no direct event association. The mailers rely on this to render the event block.
maebeale
force-pushed
the
maebeale/bulk-payment-emails
branch
3 times, most recently
from
4886068 to
34897d5
Compare
bundler-audit (CI scan_ruby) flags net-imap 0.6.4 for CVE-2026-47240, 47241, and 47242. Conservative bump to the patched 0.6.4.1; transitive dependency, no Gemfile change needed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bulk payment submissions previously sent no email at all, unlike event registrations, so a submission could land in the database silently. Payers now receive a confirmation and staff receive an FYI for every submission, reusing the existing notification pipeline. Also fixes a stale answer_type (multiple_choice_radio -> single_select_radio) in the bulk payments request spec left behind by the enum cleanup in #1644. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2 tasks
Staff frequently submit bulk payments on someone's behalf, where the automatic confirmation to the payer is unwanted noise. Adds an admin-only "on behalf" toggle that suppresses the payer confirmation while still sending the staff FYI, and reveals the otherwise-hidden payer identity fields so the submission is attributed to the payer, not the admin. Stacked on the confirmation/FYI email branch (#1647). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
changed the base branch from
main
to
maebeale/bulk-payment-confirmation-emails
maebeale
force-pushed
the
maebeale/bulk-payment-emails
branch
from
94b6a50 to
aaa790d
Compare
maebeale
changed the title
maebeale
force-pushed
the
maebeale/bulk-payment-confirmation-emails
branch
from
b36aa95 to
7c411f1
Compare
Base automatically changed from
maebeale/bulk-payment-confirmation-emails
to
main
June 13, 2026 18:04
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes [link an issue or remove this line]
What is the goal of this PR and why is this important?
How did you approach the change?
BulkPaymentgained asend_confirmation:flag; the controller only honorson_behalffor users who can manage the event (so a guest can't suppress their own confirmation) and finds/creates the payer from the form rather than the admin.on-behalfStimulus controller reveals the payer identity fields that are normally hidden for a logged-in admin. Added a "Bulk payment on behalf" entry to the event Form actions menu.UI Testing Checklist
Anything else to add?
on_behalf_controller.js; this branch carries an identical copy.