Stop marking additional service areas as primary on registration#1742
Open
maebeale wants to merge 1 commit into
Open
Stop marking additional service areas as primary on registration#1742maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
Public registration fed both the "Primary service area" dropdown (primary_service_area_single) and the "Additional service areas" checkboxes (primary_service_area) into the same assignment that set is_primary: true on every one. A registrant who named one primary and several additional areas ended up with multiple primary sectors, so their profile/recipients display crowned every sector and "only one primary" was violated. Mark only the dropdown selection as primary, the checkboxes as additional, dedupe a sector named in both, and demote any prior primary so exactly one survives. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
primary_service_area_single) and the multi-select "Additional service areas" checkboxes (primary_service_area) into one assignment that setis_primary: trueon all of them.How did you approach the change?
is_primary: false).assign_primary_sectors→assign_sectorsto reflect that it now assigns both primary and additional.UI Testing Checklist
Anything else to add?
is_primary: true); rewritten to assert correct behavior, plus added cases for one-primary, no-duplicate, and demotion. Full service spec green (23 examples).