Rename service-area field identifiers and references to sector#1755
Open
maebeale wants to merge 1 commit into
Open
Rename service-area field identifiers and references to sector#1755maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
maebeale
commented
Jun 18, 2026
| }.freeze | ||
|
|
||
| def up | ||
| IDENTIFIER_RENAMES.each do |old_identifier, new_identifier| |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: field_identifier is a persisted, indexed column, so existing FormField records need this bulk rename — without it, forms already in the DB would keep the old identifier and silently lose their dynamic sector options. Reversible via down.
maebeale
force-pushed
the
maebeale/rename-service-area-to-sector
branch
from
b9c2fc3 to
644a96e
Compare
The professional-info "Primary/Additional service area" questions are really about sectors — their options come from the Sectors admin — so the underlying form field identifiers, constants, methods, and seed/spec references are renamed to match the user-facing "sector" wording introduced in #1750. A data migration renames the persisted field_identifier values on existing FormField records so dashboards and registration keep working. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/rename-service-area-to-sector
branch
from
644a96e to
f4e483c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
primary_service_area→primary_sector,primary_service_area_single→primary_sector_single) and the constants/methods/locals/comments that referenced "service area" across models, helpers, services, views, seeds, and specs.field_identifiervalues on existingFormFieldrecords (the column is persisted and indexed), so dashboards, the recipients page, and public registration keep resolving sectors for forms already in the database.UI Testing Checklist
Anything else to add?