Add facilitator/job affiliation helpers and wire scholarship recipients page#1757
Draft
maebeale wants to merge 2 commits into
Draft
Add facilitator/job affiliation helpers and wire scholarship recipients page#1757maebeale wants to merge 2 commits into
maebeale wants to merge 2 commits into
Conversation
People hold two affiliations to the same org — a real job and an "AWBW Facilitator" role — that drive different scholarship-page display data, so each side needs an explicit, intention-revealing accessor rather than ad-hoc title filtering at each call site. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The recipients header filtered affiliations inline (event-date-active, non-facilitator) and showed that org + title. Switch it to the shared Person helpers so it matches the scholarships index: program org + its city/state from the facilitator affiliation, job title from the real-job affiliation. Preload affiliations → organization → addresses on the dashboard query so the new city/state cell adds no per-row queries. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
Person#facilitator_affiliation/#job_affiliationhelpers (active, most-recent; in-memory selection to reuse preloaded affiliations) and reducedprogram_organizationtofacilitator_affiliation&.organization; added theAffiliation.jobsscope to pair with.facilitators.program_location(city/state) and the job title, and preloadedaffiliations → organization → addresseson the dashboard query so the new city/state cell adds no per-row queries.UI Testing Checklist
events/:id/scholarships, each recipient shows their program org (linked), its city/state, and their real-job title — not the "Facilitator" title.Anything else to add?
credentialsname suffix, and primary/additional ages (now that age categories carryis_primary).