Make registration ticket callout pages publicly readable#1759
Merged
Conversation
The callout detail page is a public read reached from a registration ticket link, so it must stay viewable even when the event is unpublished or ended — mirroring Event#show? wrongly locked out registrants of non-public events. Introduce RegistrationTicketCalloutPolicy so show? is open to everyone while reorder persistence stays gated to event managers via update?. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 18, 2026
| # callout id is scoped to its event, so there is nothing sensitive to gate. | ||
| def show? | ||
| true | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: show? returns true deliberately — the callout id is scoped to its event in the controller lookup, so there's nothing sensitive to gate, and registrants of unpublished/ended events must still reach these pages.
Collaborator
Author
|
@jmilljr24 they were locked out of the callout show page bc the event is hidden |
Collaborator
LOL never would have crossed my mind. |
Collaborator
|
AI @maebeale The same issue remains for the "Art supplies" / "Before you attend" details page (events#details) and the CE hours page (events#ce_hours). both still alias to EventPolicy#show?. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Event#show?, which wrongly locked out registrants of unpublished or ended events — the very people who follow these linksHow did you approach the change?
RegistrationTicketCalloutPolicywithshow?open to everyone andupdate?(drag-reorder persistence) gated to event managersshow/updateactions at the callout policy instead of the event policyAnything else to add?
🤖 Generated with Claude Code