Track event-reg transfers via a back-link (fix lost attendance on transfer-in) - #2044
Open
maebeale wants to merge 6 commits into
Open
Track event-reg transfers via a back-link (fix lost attendance on transfer-in)#2044maebeale wants to merge 6 commits into
maebeale wants to merge 6 commits into
Conversation
maebeale
marked this pull request as ready for review
August 2, 2026 13:34
maebeale
force-pushed
the
maebeale/issue-1944
branch
from
August 2, 2026 22:31
abd066d to
3613ba0
Compare
maebeale
force-pushed
the
maebeale/issue-1944
branch
from
August 3, 2026 02:58
3613ba0 to
b34dcfa
Compare
Add transferred_from_registration_id (self-FK) so an incoming registration points back at the one it transferred out of. The in-record keeps its own real attendance status, fixing the loss of attendance data when it was marked "transferred_in"; an out stays identifiable by its terminal status. Adds a follow-up screen to record/link the destination after marking transferred out. Closes #1944 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cover the transferred_from/to associations, transferred_in?/transfer_destination_pending?, the post-save redirect to the transfer screen, and the transfer create/link flow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A facilitator training only transfers to another facilitator training, and a non-training only to another non-training, so the destination picker matches the source event's facilitator_training flag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Integrates with main's dashboard status breakdown (#2041): transferred_in is no longer an attendance status, so its row raised KeyError on ATTENDANCE_STATUS_LABELS.fetch and drilled into an empty roster filter. Remove the row and update the status-based specs accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Transferred-in is now an FK-backed dimension (an incoming reg keeps its own attendance status), so designate it wherever status is shown: - roster badge gains an "In" marker alongside the real status - dashboard attendance breakdown regains a transferred-in row, counted via the transfer link with a working drill-down - the attendance-status filter (roster + reminder recipients) offers a "Transferred in" option, routed through the attendance_status scope to the FK - CSV exports annotate the Status column with "(transferred in)" Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/issue-1944
branch
from
August 4, 2026 05:12
51c90b7 to
7711748
Compare
An incoming registration's scholarship/CE/payments stay on the source reg it transferred from. This makes that concrete across the app: - Transfer follow-up now fires from every status-change entry point — the inline roster/onboarding Turbo badge, not just the edit-form save. - The edit form shows a distinct, read-only "financials on the original registration" summary (payment/scholarship/CE) that links back to the source reg's section anchors, instead of its own editable cards. Added anchor ids to the scholarship and CE cards. - A transferred-in reg no longer reads as owing this event: payment_status_label says "Transferred in", readiness stops flagging "Payment due", and payment access derives from the source. - Reporting excludes transferred-in regs from the new event's financial totals (dashboard billable basis + revenue figures, kept in parity) and from the bulk payment allocation list, while still counting them in headcount/attendance. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 5 Inspect 🔬 self-FK + data migration, status-list change, transfer flow, and financials-on-source semantics across reporting
Closes #1944
What is the goal of this PR and why is this important?
transferred_inoverwrote its attendance status, losing whether the person actually attended the event they transferred into.transferred_from_registration_idself-FK lives on the incoming record; the out stays identifiable by its terminaltransferred_outstatus. Chained transfers form a linked list back to the original.The transfer flow
Financials stay on the source registration
payment_status_label= "Transferred in", readiness stops flagging "Payment due", and payment access derives from the source.Reporting
Surfaced as a dimension (it's no longer a status)
Known non-goals (flag if wanted)
unpaid) still buckets a transferred-in reg as unpaid.