Recipients: mute chips, link age chips + registration, group by funder - #2054
Open
maebeale wants to merge 3 commits into
Open
Recipients: mute chips, link age chips + registration, group by funder#2054maebeale wants to merge 3 commits into
maebeale wants to merge 3 commits into
Conversation
maebeale
marked this pull request as ready for review
August 2, 2026 22:25
maebeale
force-pushed
the
maebeale/scholarship-recipients-chips
branch
from
August 2, 2026 22:26
5378a5d to
957eece
Compare
The scholarship recipients page is about scholarships, so the loud lime sector/age chips were pulling focus. Mute both to a calm neutral grey here, make the age chips drill into the taggings filter the way sector chips already do (they were plain, non-clickable spans), add a per-name link to the person's registration, and add a toggle to group the roster by funder with a header per funder. The card markup moves into a shared partial so the flat and grouped lists render it once. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The switch is a "hide" control but rendered fuchsia/on by default even though nothing is hidden to start, reading as if hiding were active. Tie its on-state to hidden instead, so it sits grey/off while the status is shown (the default) and only lights up once hidden. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
When grouped by funder, the header was a faint grey line that didn't read as a section boundary. Make it a bold dark-fuchsia band, link the funder name to the donor's profile (org or person), and show the donor's city/state — read from the donor's first active address so it works for either donor type. Drop the now-redundant per-card "Funded by" line while grouped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/scholarship-recipients-chips
branch
from
August 4, 2026 05:41
957eece to
d46b7e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 mostly view work, but the shared age-chip partial now links on 5 pages and there's a new dashboard grouping method
Changes to the scholarship recipients page (and the shared chip partials it uses):
muted:local on both partials) instead of the loud lime, so they stop pulling focus on a page that's about scholarships.category_names_all=) the same way sector chips already do; previously they were plain, non-clickable spans. This applies everywhere theshared/_age_group_tagspartial is used, matching the sector chips beside them.UnfundedandNo scholarship yetare pinned last. The now-redundant per-card "Funded by" line is hidden while grouped. Backed byEventDashboard#scholarship_applicants_by_funder.events/_recipient_cardso the flat and grouped lists share it.Testing
EventDashboard#scholarship_applicants_by_fundergrouping/ordering + donor/location specs