Keep scholarship status toggle label fixed and default it on - #2102
Merged
Conversation
The switch label flipped between "Show"/"Hide", which reads as the action rather than the state. Make it a fixed "Show scholarship status" describing the feature, and align the Stimulus default with the view (shown on). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
August 5, 2026 15:33
The label no longer flips to "Hide scholarship status"; assert the static "Show scholarship status" text. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 1 Skim 👀 tiny toggle label/default change, no logic
What is the goal of this PR and why is this important?
How did you approach the change?
labeltarget.showndefault (true) with the view so it's on by default even without the explicit attribute. Fuchsia on-state unchanged.