Affiliations: default start date to the actual date, not first of month - #2176
Draft
maebeale wants to merge 3 commits into
Draft
Affiliations: default start date to the actual date, not first of month#2176maebeale wants to merge 3 commits into
maebeale wants to merge 3 commits into
Conversation
The facilitator affiliation minted on registration was dated to the first of the training's month, which read as "affiliated since the month before" when a training landed early in a month. Start it on the training date itself instead. Likewise default the manual "+ Add Affiliation" row to today rather than the first of the current month. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Now that facilitator affiliations start on the training date rather than the first of its month, a facilitator affiliation started earlier that same month should still count toward the org's activity. Reference the actual training date instead of the 1st of the month. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small default-date change in one service + one form default, plus a matching reporting-reference tweak
What is the goal of this PR and why is this important?
How did you approach the change?
AffiliationServices::CreateFromRegistration#facilitator_start_date: dropped.beginning_of_month.affiliations/_fields.html.erb: new-rowstart_datedefaultDate.current.beginning_of_month→Date.current.EventRegistration#program_statuses: reference dateevent.start_date.beginning_of_month→event.start_date.to_date.#program_statuses) and stale comments.Anything else to add?
mainand straddles thedonor→funderrename; one unrelatedevent_dashboard_specexample fails on that staleness (passes onmain). Worth a rebase before merge.