Open
Conversation
postmodern
requested changes
Feb 18, 2026
Member
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
YAML formatting is a bit off.
| url: https://github.com/rack/rack/security/advisories/GHSA-mxw3-3hh2-x2mh | ||
| title: Rack has a Directory Traversal via Rack:Directory | ||
| date: 2026-02-17 | ||
| description: "## Summary\n\n`Rack::Directory`’s path check used a string prefix match |
Member
There was a problem hiding this comment.
description: should be block text, not a quoted string. It appears that code blocks can confuse YAML's formatting.
| patched_versions: | ||
| - "~> 2.2.22" | ||
| - "~> 3.1.20" | ||
| - ">= 3.2.5" |
Member
There was a problem hiding this comment.
YAML Array elements should be indented by two spaces.
| url: | ||
| - https://github.com/rack/rack/security/advisories/GHSA-mxw3-3hh2-x2mh | ||
| - https://github.com/rack/rack/commit/75c5745c286637a8f049a33790c71237762069e7 | ||
| - https://github.com/advisories/GHSA-mxw3-3hh2-x2mh |
Member
There was a problem hiding this comment.
YAML Array elements should be indented by two spaces.
| patched_versions: | ||
| - "~> 2.2.22" | ||
| - "~> 3.1.20" | ||
| - ">= 3.2.5" |
Member
There was a problem hiding this comment.
YAML Array elements should be indented by two spaces.
| url: | ||
| - https://github.com/rack/rack/security/advisories/GHSA-whrj-4476-wvmp | ||
| - https://github.com/rack/rack/commit/f2f225f297b99fbee3d9f51255d41f601fc40aff | ||
| - https://github.com/advisories/GHSA-whrj-4476-wvmp |
Member
There was a problem hiding this comment.
YAML Array elements should be indented by two spaces.
Contributor
|
Known issue - hopefully the GHSA sync script could be changed to make this problem go away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added two new Rack vulnerabilities that GitHub security scanning has alerted me to.
Hopefully these files are OK (they've passed the required tests)