Open
Conversation
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just made two amendments to the GHSA sync script to fix issues I noticed when using it recently:
Correct the generation of the vulnerabilities references
Currently the references nest an additional
url:key inside them, which causes the RSpec tests to failTranslate two package names that appear to have been renamed at some point
arabic-prawnandredclothapparently previously used camel-cased names (Arabic-PrawnandRedCloth) which is how they're stored in the repository. The sync script creates 'new' vulnerabilities because of these changes, so I've translated these package names back to avoid this.