Open
Conversation
tothtamas28
reviewed
Apr 8, 2026
|
|
||
| @abstractmethod | ||
| def custom_step(self, c: CTerm, cs: CTermSymbolic) -> KCFGExtendResult | None: ... | ||
| def custom_step(self, c: CTerm, cs: CTermSymbolic, node_id: int) -> KCFGExtendResult | None: ... |
Contributor
There was a problem hiding this comment.
What's the intended semantics of the node_id? Should it be optional?
Contributor
Author
There was a problem hiding this comment.
I don't see why it should be optional since node_id is always passed to it in extend_cterm. It is however optional for use by the custom step. Most custom steps will not make use of this. Only the _exec_console_log_custom_step custom step from runtimeverification/kontrol#1131 so far would make use of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter that is passed to custom steps in pyk. Specifically, the
node_idis passed so that it can be used in downstream custom steps.This is required for a downstream PR in kontrol (runtimeverification/kontrol#1131) that adds the node id to console log cheatcode logging, which is implemented by means of a custom step.
This PR will require adjustments in some downstream dependencies as well such as kevm. However, not all downstream dependencies make use of custom steps such as, e.g., wasm-semantics and komet.