Annotate Wasm AST nodes (Instrs) with bytecode position metadata for tracing/debugging#753
Draft
bbyalcinkaya wants to merge 6 commits intomasterfrom
Draft
Annotate Wasm AST nodes (Instrs) with bytecode position metadata for tracing/debugging#753bbyalcinkaya wants to merge 6 commits intomasterfrom
Instrs) with bytecode position metadata for tracing/debugging#753bbyalcinkaya wants to merge 6 commits intomasterfrom
Conversation
Instrs) with bytecode position metadata for tracing/debugging
RaoulSchaffranek
approved these changes
Apr 8, 2026
Comment on lines
+337
to
+338
| Helper wrapper to attach source position metadata to instructions for tracing/debugging. | ||
| `posStart` and `posEnd` represent the byte/code offsets of the instruction in the original Wasm bytecode file. |
Member
There was a problem hiding this comment.
Can you clarify if postStart and postEnd start at 0 or 1, and if they're inclusive or exclusive?
Also, it might be worth considering using an offset+length pair instead of a start+end pair for consistency with Python coding conventions.
Member
Author
There was a problem hiding this comment.
Thanks. I switched to an offset + length representation and added more comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for position-annotated instructions in the Wasm AST, enabling execution traces to carry bytecode position metadata for debugging.
Changes
py-wasmto the version that supports this feature (currently linked to a branch; will point to the released version once the correspondingpy-wasmPR is merged)#instrWithPos(inner: Instr, posStart: Int, posEnd: Int)syntaxwasm2kastto handle wrapped instructionsNotes
InstructionWithPosand will not function correctly until that PR is merged.