Skip to content

Enable use of Unix sockets to connect to DB in tests #12446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jtgeibel wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Enable use of Unix sockets to connect to DB in tests #12446

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
168b738
Default to unix socket if `TEST_DATABASE_URL` has no host
jtgeibel Nov 16, 2025
a9d6ca1
Enable ChoasProxy to connect to unix sockets
jtgeibel Nov 16, 2025
f8e2f46
Drop `cfg`s for non unix platforms
jtgeibel Nov 22, 2025
083cc44
ChaosProxy: accept then immediately drop connection
jtgeibel Dec 3, 2025
3b3a4a6
ChaosProxy: Proxy over Unix socket instead of TCP
jtgeibel Dec 3, 2025
7955aad
Default sample env to connect to DB via Unix socket
jtgeibel Dec 3, 2025
751c200
Correctly handle `host=` query param in `TEST_DATABASE_URL`
jtgeibel Dec 4, 2025
29fbf38
Default to a Unix socket if no database host is provided
jtgeibel Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ pub async fn oneoff_connection() -> anyhow::Result<AsyncPgConnection> {
pub fn connection_url(config: &config::DbPoolConfig) -> String {
let mut url = Url::parse(config.url.expose_secret()).expect("Invalid database URL");

// Support `postgres:///db_name` shorthand for easier local development.
if url.host().is_none() {
maybe_append_url_param(&mut url, "host", "/run/postgresql");
}
Comment on lines +29 to +32
Copy link
Member

@Turbo87 Turbo87 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I'm okay with this default for the testing setup, I'm not sure we want to use the same for production. Is there anything preventing you from specifying /run/postgresql directly in the DATABASE_URL env var?


if config.enforce_tls {
maybe_append_url_param(&mut url, "sslmode", "require");
}
Expand Down
Loading