feat: add efiapi support for loongarch64 #149879
Conversation
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
There was a problem hiding this comment.
Thanks! I'm unfamiliar with LoongArch, so I'll ping the target maintainers:
@rustbot ping loongarch
I'm also a bit unsure of the process, but I think this'll need a lang FCP. But let's get to that once the implementation is a bit more fleshed out.
| LoongArch64, | ||
| /// Architectures which don't need other considerations for ABI lowering | ||
| Other, | ||
| } |
There was a problem hiding this comment.
Should support be added in InlineAsmClobberAbi::parse as well?
There was a problem hiding this comment.
Actually, that was intentionally not done in #111499, so I'm unsure here?
| LoongArch64, | ||
| /// Architectures which don't need other considerations for ABI lowering | ||
| Other, | ||
| } |
There was a problem hiding this comment.
The reference should be updated as well:
https://doc.rust-lang.org/reference/items/external-blocks.html#r-items.extern.abi.efiapi
| (ExternAbi::EfiApi, ArchKind::Aarch64 | ArchKind::Riscv | ArchKind::X86) => CanonAbi::C, | ||
| ( | ||
| ExternAbi::EfiApi, | ||
| ArchKind::Aarch64 | ArchKind::Riscv | ArchKind::X86 | ArchKind::LoongArch64, |
There was a problem hiding this comment.
Why only LoongArch64? Isn't LoongArch32 the same?
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
Error: This team ( Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
|
Oh well, pinging loongarch people manually then: @heiher, @xiangzhai, @xen0n, @xry111 |
|
Thanks for your patch. Since LoongArch currently lacks basic UEFI support, adding |
4 participants
To fix: #149877
Support extern "efiapi" for target loongarch64