Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Dec 12, 2025

Part of #149865.

This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall).

Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate.

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 12, 2025
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the malformed-attribute-suggestions branch from c424cd9 to d025cde Compare December 12, 2025 13:55
@JonathanBrouwer
Copy link
Contributor

r=me when CI is green

@JonathanBrouwer
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 12, 2025

📌 Commit d025cde has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 12, 2025
…-suggestions, r=JonathanBrouwer

If there are too many suggestions for malformed attribute, do not suggest them

Part of rust-lang#149865.

This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall).

Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate.

r? `@JonathanBrouwer`
@GuillaumeGomez
Copy link
Member Author

This one will likely break when put in a rollup so:

@bors p=1 rollup=iffy

@bors
Copy link
Collaborator

bors commented Dec 12, 2025

⌛ Testing commit d025cde with merge fa5eda1...

@bors
Copy link
Collaborator

bors commented Dec 12, 2025

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing fa5eda1 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 12, 2025
@bors bors merged commit fa5eda1 into rust-lang:main Dec 12, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 12, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3391c01 (parent) -> fa5eda1 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fa5eda19b95201468f5b1c5c035ec2fc06fccd66 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3173.3s -> 4078.6s (+28.5%)
  2. dist-x86_64-musl: 7798.6s -> 6920.8s (-11.3%)
  3. dist-aarch64-apple: 7453.6s -> 6693.0s (-10.2%)
  4. aarch64-gnu-llvm-20-2: 2504.9s -> 2251.0s (-10.1%)
  5. x86_64-msvc-2: 6779.2s -> 7433.7s (+9.7%)
  6. dist-x86_64-illumos: 5916.6s -> 6356.9s (+7.4%)
  7. dist-x86_64-llvm-mingw: 7217.7s -> 7736.1s (+7.2%)
  8. aarch64-gnu-llvm-20-1: 3639.5s -> 3378.5s (-7.2%)
  9. x86_64-gnu-llvm-20: 2643.4s -> 2822.9s (+6.8%)
  10. x86_64-gnu-aux: 6588.2s -> 7027.9s (+6.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fa5eda1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.9% [-0.9%, -0.9%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.2%, -2.0%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.663s -> 473.976s (0.07%)
Artifact size: 389.32 MiB -> 389.30 MiB (-0.00%)

@GuillaumeGomez GuillaumeGomez deleted the malformed-attribute-suggestions branch December 13, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants