Skip to content

refactor rustc_hir_typeck/src/op.rs#154223

Open
malezjaa wants to merge 1 commit intorust-lang:mainfrom
malezjaa:refactor-typecheck-op
Open

refactor rustc_hir_typeck/src/op.rs#154223
malezjaa wants to merge 1 commit intorust-lang:mainfrom
malezjaa:refactor-typecheck-op

Conversation

@malezjaa
Copy link
Contributor

@malezjaa malezjaa commented Mar 22, 2026

Fixes #64297

This is a refactoring PR with no logic or behaviour changes. I tried to improve readability of op.rs, which had a few very large functions using some suboptimal syntax. I broke these up into smaller helpers.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2026

r? @adwinwhite

rustbot has assigned @adwinwhite.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 13 candidates

@rust-log-analyzer

This comment has been minimized.

@malezjaa malezjaa force-pushed the refactor-typecheck-op branch from 60bad65 to f803f56 Compare March 22, 2026 19:53
@Kivooeo
Copy link
Member

Kivooeo commented Mar 22, 2026

This is a fairly large PR -- could you help reviewers by adding some context to the description? It would be great to have a summary of what was changed, the key decisions made and the reasoning behind them, and ideally a breakdown into separate commits to make it easier to review piece by piece.

@malezjaa
Copy link
Contributor Author

Updated the description. There weren't really any key decisions to make since this is a refactor with no behaviour changes. As for separate commits, splitting style changes after the fact would be tedious and I'm not sure it would add much value for reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: Refactor rustc_typeck/check/op.rs

5 participants