Skip to content

Move ui/issues tests to relevant subdirectories#154233

Open
kyleecodes wants to merge 3 commits intorust-lang:mainfrom
kyleecodes:tests/reorg-ui-issues
Open

Move ui/issues tests to relevant subdirectories#154233
kyleecodes wants to merge 3 commits intorust-lang:mainfrom
kyleecodes:tests/reorg-ui-issues

Conversation

@kyleecodes
Copy link

@kyleecodes kyleecodes commented Mar 23, 2026

Related to #133895 and Reorganisation of tests/ui/issues for GSOC

This is the first PR in a batch of PRs.

Moves ui/issues/issue-17546.rs‎ ‎-> ui/variants/variant-result-noresult-used-as-type.rs

Approach:

  1. Check linked issue and test contents, determine new target directory
  2. Move / rename tests to reflect purpose.
  3. Add issue link / comments in separate commit.
  4. Rebless if necessary and remove obsolete stderr.

r? @Kivooeo

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 23, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

@rustbot rustbot assigned Kivooeo and unassigned jieyouxu Mar 23, 2026
@kyleecodes kyleecodes marked this pull request as draft March 23, 2026 03:14
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026
@kyleecodes kyleecodes changed the title Migrate test/ui/issues tests to more relevant test/ui subdirectories Migrate test/ui/issues tests to relevant subdirectories Mar 23, 2026
@kyleecodes
Copy link
Author

kyleecodes commented Mar 23, 2026

Marked draft to modify the target directory.

Also, I'll keep all commit msgs the same format moving forward. Happy to fix that here if needed.

@kyleecodes kyleecodes changed the title Migrate test/ui/issues tests to relevant subdirectories Move ui/issues tests to relevant subdirectories Mar 23, 2026
@kyleecodes kyleecodes marked this pull request as ready for review March 23, 2026 16:23
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2026
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! you don't need to bless in the first (move) commit, since you'll rebless anyway after adding metadata in the next one (and the move commit should only consist of moves.) . It makes less noise in the diff if you just move first, then bless + add metadata together.

Copy link
Author

@kyleecodes kyleecodes Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, with issue links updating stderr line numbers. I'll update my approach to separate the move, then commit rebless with metadata / code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants