Move ui/issues tests to relevant subdirectories#154233
Move ui/issues tests to relevant subdirectories#154233kyleecodes wants to merge 3 commits intorust-lang:mainfrom
Conversation
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Marked draft to modify the target directory. Also, I'll keep all commit msgs the same format moving forward. Happy to fix that here if needed. |
There was a problem hiding this comment.
Hey! you don't need to bless in the first (move) commit, since you'll rebless anyway after adding metadata in the next one (and the move commit should only consist of moves.) . It makes less noise in the diff if you just move first, then bless + add metadata together.
There was a problem hiding this comment.
Makes sense, with issue links updating stderr line numbers. I'll update my approach to separate the move, then commit rebless with metadata / code changes.
Related to #133895 and Reorganisation of tests/ui/issues for GSOC
This is the first PR in a batch of PRs.
Moves
ui/issues/issue-17546.rs->ui/variants/variant-result-noresult-used-as-type.rsApproach:
r? @Kivooeo