Account for type alias projections in E0308 "expected/found" shortening logic#159189
Open
estebank wants to merge 5 commits into
Open
Account for type alias projections in E0308 "expected/found" shortening logic#159189estebank wants to merge 5 commits into
estebank wants to merge 5 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
chenyukang
reviewed
Jul 13, 2026
chenyukang
reviewed
Jul 13, 2026
…ng logic
When encountering a E0308 error involving `ty::Projection`s, highlight only the sub-parts that are actually relevant:
```
error[E0308]: mismatched types
--> tests/ui/associated-types/long-type-E0308.rs:19:5
|
16 | fn foo<'a, T: FooBar>(value: T) -> <<<T::Wrapper<T> as FooBar>::Assoc as FooBar>::Assoc as FooBar>::Wrapper<<T::Assoc as FooBar>::Assoc> {
| ----------------------------------------------------------------------------------------------------- expected `<<<... as FooBar>::Assoc as FooBar>::Assoc as FooBar>::Wrapper<...>` because of return type
...
19 | value.assoc().assoc().assoc().wrap(value.assoc().assoc())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `really_really_really_long_module::FooBar::Wrapper`, found `really_really_really_long_module::FooBar::Assoc`
|
= note: expected associated type `<<<<_ as FooBar>::Wrapper<T> as FooBar>::Assoc as FooBar>::Assoc as FooBar>::Wrapper<_>`
found associated type `<<<<_ as FooBar>::Assoc as FooBar>::Assoc as FooBar>::Assoc as FooBar>::Wrapper<_>`
= note: an associated type was expected, but a different one was found
= note: the full name for the type has been written to 'long-type-E0308.long-type-5396540309891820670.txt'
= note: consider using `--verbose` to print the full type name to the console
```
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering a E0308 error involving
ty::Projections, highlight only the sub-parts that are actually relevant:Partially address #159043. To close that ticket we also need to modify the type shortening logic to allow for a mechanism to keep relevant sub-types as visible when possible, we need to expand this logic to account for other
ty::Aliases, and deduplicate some of the existing highlighting logic.r? @chenyukang